]> dgit.raspbian.org Git - gnome-shell.git/commit
Connect to DnD signals using connectObject()
authorJonas Dreßler <verdre@v0yd.nl>
Sat, 5 Nov 2022 21:36:47 +0000 (22:36 +0100)
committerJonas Dreßler <verdre@v0yd.nl>
Wed, 30 Jul 2025 20:40:59 +0000 (22:40 +0200)
commitd1b20f0b38f76037855cdde488ec4fc959d35678
tree65bbff1e68e6bfeb22a1d6dbe3b77dbbd2bfa205
parentb3e5a524d382c227c2a75838791f315812c07265
Connect to DnD signals using connectObject()

Currently DnD uses `disconnectAll()` in a `::destroy` signal handler for
the drag actor. This is a little weird, as usually the connecting object
is in charge of disconnecting as well.

Since we have some nice convenience API for this nowadays, use
`connectObject()` when connecting to DnD signals in the various draggable
actors that we have, which ensures the signal is disconnected as soon as
the draggable actors get destroyed.

This allows removing the call to `disconnectAll()` in DnD.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3796>
js/ui/appDisplay.js
js/ui/dnd.js
js/ui/windowPreview.js
js/ui/workspaceThumbnail.js